OCPBUGS-84513: remove openshift-cluster-version terminationMessagePolicy exemption by jrangelramos · Pull Request #31359 · openshift/origin

jrangelramos · 2026-06-30T20:23:29Z

Summary

Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.
- These containers are now assessed using the standard logic, which adjusts fail vs. flake behavior for older-version scenarios for more accurate results.

openshift-merge-bot · 2026-06-30T20:23:34Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-06-30T20:23:46Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload

Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-30T20:24:15Z

Walkthrough

The termination message policy monitor test no longer grandfather-exempts the openshift-cluster-version namespace, so its containers use the remaining violation classification logic.

Changes

Termination Message Policy Exception Removal

Layer / File(s)	Summary
Remove grandfathered exception entry `pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go`	Removes the `existingViolations["openshift-cluster-version"]` entry from the exception map, changing namespace classification during test generation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: deads2k, sjenning

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only removes an exemption in CollectData; no It/Describe/Context/When titles were added or changed, and the affected file contains no Ginkgo test declarations.
Test Structure And Quality	✅ Passed	PASS: The PR only removes an exemption in a monitor analyzer; no Ginkgo It/BeforeEach/Eventually test structure or timeout patterns were added or changed.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e test was added; the diff only removes one grandfathered namespace exemption in an existing monitor analyzer.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The only change is a monitor-test whitelist removal in pkg/monitortests/...; no new Ginkgo It/Describe/Context/When blocks or node-topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a monitor-test exemption was removed; no manifests, controllers, or scheduling constraints were added or changed.
Ote Binary Stdout Contract	✅ Passed	Diff only removes the openshift-cluster-version exemption; no stdout writes or logging changes were added in init/main/suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests or IP/connectivity logic were added; this PR only removes a grandfathered violation entry in a monitor test.
No-Weak-Crypto	✅ Passed	Changed file only removes a namespace exemption in a monitor test; no weak-crypto APIs, custom crypto, or secret/token comparisons are present.
Container-Privileges	✅ Passed	Only the monitor test exemption changed; no privileged/root/host* or allowPrivilegeEscalation settings were added or modified.
No-Sensitive-Data-In-Logs	✅ Passed	No logging was added; the only code change is an allowlist removal, and the file/subtree has no sensitive-data logging patterns.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the removal of the openshift-cluster-version terminationMessagePolicy exemption.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-06-30T21:03:33Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

jrangelramos · 2026-07-03T10:55:03Z

/retest-required

jrangelramos · 2026-07-03T18:06:47Z

/retest-required

jrangelramos · 2026-07-06T15:07:30Z

/retest-required

openshift-ci-robot · 2026-07-07T18:02:56Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload

Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes

Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.

These containers are now evaluated using the standard logic (rather than being exempt), improving the accuracy of the resulting fail/flake behavior in older-version scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-07-07T18:42:25Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

wking · 2026-07-15T16:11:04Z

/retest-required

…Policy exemption The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in update-payload pods. Remove the corresponding exemption from the monitor test so violations are enforced as hard failures. Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-07-20T14:02:22Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

sosiouxme · 2026-08-18T19:04:40Z

/lgtm
/approve
/retest-required

openshift-ci · 2026-08-18T19:06:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-08-19T12:00:29Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is invalid:

expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Summary

Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload

Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes

Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.

These containers are now assessed using the standard logic, which adjusts fail vs. flake behavior for older-version scenarios for more accurate results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jrangelramos · 2026-08-19T12:13:38Z

/jira refresh

openshift-ci-robot · 2026-08-19T12:13:42Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is invalid:

expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jrangelramos · 2026-08-19T12:14:44Z

/jira refresh

openshift-ci-robot · 2026-08-19T12:14:50Z

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jrangelramos · 2026-08-19T12:16:31Z

/verified by @jrangelramos

checked sippy dptool page

openshift-ci-robot · 2026-08-19T12:16:43Z

@jrangelramos: This PR has been marked as verified by @jrangelramos.

Details

In response to this:

/verified by @jrangelramos

checked sippy dptool page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-19T13:30:50Z

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-08-19T13:34:52Z

@jrangelramos: Jira Issue Verification Checks: Jira Issue OCPBUGS-84513
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84513 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload

Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes

Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.

These containers are now assessed using the standard logic, which adjusts fail vs. flake behavior for older-version scenarios for more accurate results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-08-20T12:48:21Z

Fix included in release 5.1.0-0.nightly-2026-08-20-065836

jrangelramos · 2026-08-20T13:12:16Z

/cherry-pick release-5.0

openshift-cherrypick-robot · 2026-08-20T13:13:06Z

@jrangelramos: new pull request created: #31539

Details

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2026

openshift-ci Bot requested review from deads2k and sjenning June 30, 2026 20:24

coderabbitai Bot approved these changes Jun 30, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 30, 2026

openshift-ci-robot mentioned this pull request Jul 3, 2026

OCPBUGS-84513: set terminationMessagePolicy on update-payload pods openshift/cluster-version-operator#1417

Merged

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026

jrangelramos force-pushed the OCPBUGS-84513 branch from 737ed83 to bd94cbc Compare July 7, 2026 18:01

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 7, 2026

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2026

jrangelramos force-pushed the OCPBUGS-84513 branch from bd94cbc to 12a67fd Compare July 20, 2026 12:54

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2026

openshift-ci Bot assigned sosiouxme Aug 18, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 19, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 19, 2026

openshift-merge-bot Bot merged commit b4369f0 into openshift:main Aug 19, 2026
22 checks passed

jrangelramos deleted the OCPBUGS-84513 branch August 19, 2026 19:26

openshift-cherrypick-robot mentioned this pull request Aug 20, 2026

[release-5.0] OCPBUGS-112340: remove openshift-cluster-version terminationMessagePolicy exemption #31539

Open

Uh oh!

Conversation

jrangelramos commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Dependencies

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

openshift-ci-robot commented Jun 30, 2026

Summary

Context

Dependencies

Test plan

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

jrangelramos commented Jul 3, 2026

Uh oh!

jrangelramos commented Jul 3, 2026

Uh oh!

jrangelramos commented Jul 6, 2026

Uh oh!

openshift-ci-robot commented Jul 7, 2026

Summary

Context

Dependencies

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 7, 2026

Uh oh!

wking commented Jul 15, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

sosiouxme commented Aug 18, 2026

Uh oh!

openshift-ci Bot commented Aug 18, 2026

Uh oh!

openshift-ci-robot commented Aug 19, 2026

Summary

Context

Dependencies

Test plan

Summary by CodeRabbit

Uh oh!

jrangelramos commented Aug 19, 2026

Uh oh!

openshift-ci-robot commented Aug 19, 2026

Uh oh!

jrangelramos commented Aug 19, 2026

Uh oh!

openshift-ci-robot commented Aug 19, 2026

Uh oh!

jrangelramos commented Aug 19, 2026

Uh oh!

openshift-ci-robot commented Aug 19, 2026

Uh oh!

openshift-ci Bot commented Aug 19, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 19, 2026

Summary

Context

Dependencies

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented Aug 20, 2026

Uh oh!

jrangelramos commented Aug 20, 2026

jrangelramos commented Jun 30, 2026 •

edited

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading